Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional vim plugin names #64085

Merged
merged 19 commits into from Jul 2, 2019

Conversation

paulreimer
Copy link
Contributor

Motivation for this change
  • vim-plugin-names should be sorted (resolved that before adding anything)
  • Added some vim plugins that I personally use for development
Things done

Not much. Various new plugins appear to be working as they normally do.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jul 2, 2019

thanks but the history is a mess, please see how similar PRs did it. When adding a plugin, the commit should be vimPlugins.<name>: init at X.Y so that nixos' bot can pickup some of the changes.

@paulreimer
Copy link
Contributor Author

Should each commit introducing a new plugin include the (re)generated generated.nix? Or separate commits?

@kalbasit
Copy link
Member

kalbasit commented Jul 2, 2019

Should each commit introducing a new plugin include the (re)generated generated.nix? Or separate commits?

It should include the generated.nix file.

@teto
Copy link
Member

teto commented Jul 2, 2019

well Ideally you would git add -p the added plugin and have the updates for already existing plugins in a separate commit.
To sum up:
1/ a commit that updates existing plugins
2/ a list of commits with each commit adding the plugin: vimPlugins.: init at X.Y

@paulreimer paulreimer force-pushed the additional-vim-plugin-names branch from 4af2de9 to a35552e Compare July 2, 2019 07:02
@paulreimer
Copy link
Contributor Author

Alright, I've cleaned up the history for the plugins that I added.

So how should I clean up the history for the alphabetization/plugin renaming (which triggered some upgrades from update.py)? I can split it up into one commit per (alphabetized) change if that is what is needed for CI.

@teto
Copy link
Member

teto commented Jul 2, 2019

Thanks the history looks good as is.

@GrahamcOfBorg build vimPlugins.vim-flutter vimPlugins.deoplete-lsp vimPlugins.LanguageClient-neovim vimPlugins.deoplete-jedi

@kalbasit
Copy link
Member

kalbasit commented Jul 2, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim vimPlugins.file-line vimPlugins.vim-sourcetrail vimPlugins.dart-vim-plugin vimPlugins.vim-textobj-comment vimPlugins.vim-textobj-function vimPlugins.vim-textobj-user vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.lightline-ale vimPlugins.sky-color-clock-vim vimPlugins.vim-bufkill vimPlugins.deoplete-lsp vimPlugins.vim-flutter vimPlugins.tcomment_vim vimPlugins.ir_black vimPlugins.DoxygenToolkit-vim

@kalbasit kalbasit merged commit 5d12512 into NixOS:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants