New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
olm: Allow building on Darwin #63958
Conversation
This builds for me on macos 10.13, but it "enables" the reverse dependency |
Same for |
@risicle Thank you for mentioning these! Is there a command that will discover such packages or did you just grep the repository for “olm”? I’ve marked weechat-matrix-bridge and mtxclient broken under Darwin. With that done, nheko will also refuse to build (since it depends on mtxclient)—let me know if that’s sufficient or if I should explicitly mark nheko as broken too. |
I use the |
@GrahamcOfBorg build olm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, builds ok. Commits need to be re-worked to fit the contribution guide.
@kalbasit Yep, I was planning to rebase once code review was done 🙂 Thanks for taking a look! |
@bdarnell I'm sorry for the confusion. Breaking down the commit into 3 different commits (one per derivation) was correct, just the wording was not. I was expecting to see something along these lines:
Thanks! |
All of the dependencies of this package are now available on Darwin, but the package itself still fails to build on that platform.
All of the dependencies of this package are now available on Darwin, but the package itself still fails to build on that platform.
@kalbasit No worries. I’ve force pushed again; see how that looks. |
Motivation for this change
Small change to allow the “olm” package to build under Darwin (in addition to Linux).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)