Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: 1.4.2 -> 1.4.4 -> 1.5.2 #63954

Merged
merged 3 commits into from Jul 4, 2019
Merged

consul: 1.4.2 -> 1.4.4 -> 1.5.2 #63954

merged 3 commits into from Jul 4, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 30, 2019 •
edited

Motivation for this change

https://github.com/nh2/nixpkgs/pull/new/consul-1.5.2

As per changelog also fixes security bugs in dependencies:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • tested on my staging cluster
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've put in 2 upgrade commits:

  • one that upgrades to 1.4.4 (so we can cherry-pick that on 19.03)
  • one that upgrades to 1.5.2

CC co-maintainers @vdemeester @pradeepchhetri

@nh2
Copy link
Contributor Author

nh2 commented Jun 30, 2019

@GrahamcOfBorg build consul

@nh2 nh2 changed the title Consul 1.5.2 consul: 1.4.2 -> 1.4.4 -> 1.5.1 Jun 30, 2019
@nh2 nh2 changed the title consul: 1.4.2 -> 1.4.4 -> 1.5.1 consul: 1.4.2 -> 1.4.4 -> 1.5.2 Jun 30, 2019
@nh2
Copy link
Contributor Author

nh2 commented Jun 30, 2019

Oops, I hadn't seen #62921 (which upgrades to 1.5.1).

I propose we use my PR instead, as it upgrades to a later version and I've tested it in a real cluster.

CC @dtzWill

@nh2 nh2 requested a review from dtzWill June 30, 2019 15:40
@nh2 nh2 mentioned this pull request Jun 30, 2019
Closed
10 tasks
@danbst danbst merged commit d0e3c02 into NixOS:master Jul 4, 2019
@danbst
Copy link
Contributor

danbst commented Jul 4, 2019

@nh2 release-19.03 had 1.4.1 version, so I've redacted commit. I've checked that https://github.com/hashicorp/consul/blob/master/CHANGELOG.md doesn't mention any BREAKING CHANGES, so good to go.

(I've had once ruined consul cluster in an upgrade)

aef662d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @danbst @alyssais