Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toppler: init at 1.1.6 #64197

Merged
merged 1 commit into from Jul 3, 2019
Merged

toppler: init at 1.1.6 #64197

merged 1 commit into from Jul 3, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 2, 2019

Motivation for this change

Just a game

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

thorstenweber83
thorstenweber83 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@thorstenweber83 thorstenweber83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86, aarch64
  • executables tested on x86, aarch64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
    - [ ] build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
    - [ ] phases are respected
    - [ ] patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

@markuskowa
Copy link
Member

@GrahamcOfBorg build toppler

@markuskowa markuskowa merged commit a53646d into NixOS:master Jul 3, 2019
@fgaz fgaz deleted the toppler/init branch May 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenweber83 thorstenweber83 thorstenweber83 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @markuskowa @thorstenweber83