Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zaz: init at 1.0.0 #64196

Merged
merged 1 commit into from Jul 4, 2019
Merged

zaz: init at 1.0.0 #64196

merged 1 commit into from Jul 4, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 2, 2019

Motivation for this change

Pretty "famous" foss game (you can find it in most repos)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64196 passes
diff LGTM
binary works

[3 built, 6 copied (1.7 MiB), 0.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64196
1 package were build:
zaz

./results/zaz/bin/zaz # opens game

@etu etu merged commit 47cef20 into NixOS:master Jul 4, 2019
@etu
Copy link
Contributor

etu commented Jul 4, 2019

@fgaz Thanks for the package!

@jonringer Thanks for the review, it helped me greatly in testing it :)

@fgaz fgaz deleted the zaz/init branch May 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @etu @jonringer