New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openh264: 1.8.0 -> 2.0.0 #64100
openh264: 1.8.0 -> 2.0.0 #64100
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openh264/versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now it breaks two reverse-deps
- mediastreamer-openh264-0.0pre20160801
[ 25%] Building CXX object src/CMakeFiles/msopenh264.dir/msopenh264enc.cpp.o
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp: In member function 'void MSOpenH264Encoder::initialize()':
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:29: error: 'struct SSpatialLayerConfig' has no member named 'sSliceCfg'; did you mean 'sSliceArgument'?
params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
^~~~~~~~~
sSliceArgument
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:53: error: 'SM_DYN_SLICE' was not declared in this scope
params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
^~~~~~~~~~~~
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:53: note: suggested alternative: 'SM_SINGLE_SLICE'
params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
^~~~~~~~~~~~
SM_SINGLE_SLICE
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:135:29: error: 'struct SSpatialLayerConfig' has no member named 'sSliceCfg'; did you mean 'sSliceArgument'?
params.sSpatialLayers[0].sSliceCfg.sSliceArgument.uiSliceSizeConstraint = ms_factory_get_payload_max_size(mFilter->factory);
^~~~~~~~~
sSliceArgument
make[2]: *** [src/CMakeFiles/msopenh264.dir/build.make:89: src/CMakeFiles/msopenh264.dir/msopenh264enc.cpp.o] Error 1
- gst-plugins-bad-1.16.0
[614/841] Compiling C++ object 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o'.
FAILED: ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o
/nix/store/5yyx688q9qxhb4ypawq7v80fm3ix27dm-gcc-wrapper-8.3.0/bin/c++ -Iext/openh264/8008d81@@gstopenh264@sha -Iext/openh264 -I../ext/openh264 -I. -I../ -I/nix/store/3g67gjxkziv947prkql5irml1b6g10fl-glib-2.62.0-dev/include -I/nix/store/3g67gjxkziv947prkql5irml1b6g10fl-glib-2.62.0-dev/include/glib-2.0 -I/nix/store/876ljm7j1xnx5npjjvlqkqil84mn4cks-glib-2.62.0/lib/glib-2.0/include -I/nix/store/zwf051wir2gyc3j1w558mbncg7fmc1w1-gst-plugins-base-1.16.0-dev/include/gstreamer-1.0 -I/nix/store/34y4114d5bq8pq5z58lwhs15fn4haz0r-gstreamer-1.16.0-dev/include/gstreamer-1.0 -I/nix/store/wnsnxj0qjcxif12gqf65bysc8afybskl-openh264-2.0.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wno-non-virtual-dtor -fno-strict-aliasing -Wformat-nonliteral -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -fPIC -MD -MQ 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o' -MF 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o.d' -o 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o' -c ../ext/openh264/gstopenh264enc.cpp
../ext/openh264/gstopenh264enc.cpp: In function 'gboolean gst_openh264enc_set_format(GstVideoEncoder*, GstVideoCodecState*)':
../ext/openh264/gstopenh264enc.cpp:745:14: error: 'SEncParamExt' {aka 'struct TagEncParamExt'} has no member named 'bEnableSpsPpsIdAddition'
enc_params.bEnableSpsPpsIdAddition = 0;
^~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mediastreamer-openh264
fixed in #74043
gst_all_1.gst-plugins-bad
fixed upstream with release 1.16.1 -> #70690
* openh264: 1.8.0 -> 2.0.0 Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openh264/versions
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openh264/versions.
meta.description for openh264 is: '"A codec library which supports H.264 encoding and decoding"'.
meta.homepage for openh264 is: '"http://www.openh264.org"
Release on GitHub
Compare changes on GitHub
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
690 total rebuild path(s)
234 package rebuild(s)
234 x86_64-linux rebuild(s)
222 i686-linux rebuild(s)
28 x86_64-darwin rebuild(s)
206 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
adapta-gtk-theme
almanah
aravis
arc-theme
areca
astroid
audio-recorder
azureus
balsa
baresip
birdfont
bookworm
brasero
brasero-original
byzanz
chrome-gnome-shell
corebird
cutegram
deja-dup
denemo
dragon
dropbox-cli
eclipses.eclipse-cpp
eclipses.eclipse-java
eclipses.eclipse-modeling
eclipses.eclipse-platform
eclipses.eclipse-scala-sdk
eclipses.eclipse-sdk
ekiga
empathy
enlightenment.rage
eolie
ephemeral
epiphany
evince
evolution-data-server
farstream
feedreader
folks
fractal
gajim
gcompris
gfbgraph
glom
gmrender-resurrect
gnome-builder
gnome-podcasts
gnome-recipes
gnome3.bijiben
gnome3.cheese
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries: