Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.i3pystatus: drop praw #64103

Merged
merged 2 commits into from Jul 3, 2019
Merged

python3Packages.i3pystatus: drop praw #64103

merged 2 commits into from Jul 3, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jul 2, 2019

praw is a reddit wrapper that sometimes poses problems when installing
i3pystatus (twice in the past 6 months for me).
As its usage should be relatively low, it should be fine to drop.
users can go back the old behavior by overriding extraLibs

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

praw is a reddit wrapper that sometimes poses problems when installing
i3pystatus (twice in the past 6 months for me).
As its usage should be relatively low, it should be fine to drop.
users can go back the old behavior by overriding extraLibs
@teto
Copy link
Member Author

teto commented Jul 2, 2019

follow up of #64086 CC @igsha

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64103 passes
otherwise, diff LGTM

[3 built, 4 copied (0.7 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64103
1 package were build:
i3pystatus

pkgs/applications/window-managers/i3/pystatus.nix Outdated Show resolved Hide resolved
@teto teto merged commit fb0d1c5 into NixOS:master Jul 3, 2019
@teto teto deleted the i3pystatus branch July 3, 2019 03:10
@teto
Copy link
Member Author

teto commented Jul 3, 2019

thanks for the review/suggestion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants