Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

way-cooler: Mark as broken #64138

Merged
merged 2 commits into from Jul 3, 2019
Merged

way-cooler: Mark as broken #64138

merged 2 commits into from Jul 3, 2019

Conversation

matthiasbeyer
Copy link
Contributor

The project is in full-rewrite state, which also breaks backwards
compatibility.
Right now, the project README warns that way-cooler is not usable in its
current state.

Thus mark this as broken, so die-hard users can still use it.

This patch should be reverted as soon as there is a new release.

Motivation for this change

Closes #63914

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not tested at all.

@matthiasbeyer
way-cooler: Mark as broken
4457364 
The project is in full-rewrite state, which also breaks backwards
compatibility.
Right now, the project README warns that way-cooler is not usable in its
current state.

Thus mark this as broken, so die-hard users can still use it.

This patch should be reverted as soon as there is a new release.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
fixup! way-cooler: Mark as broken
bdc7da8
primeos
primeos approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be fine now :)

@primeos primeos merged commit 48afae7 into NixOS:master Jul 3, 2019
@ghost
Copy link

ghost commented Jul 3, 2019

@matthiasbeyer Cool, thank you!

@matthiasbeyer matthiasbeyer deleted the way-cooler-broken branch July 3, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat requested changes

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop way-cooler?
3 participants
@matthiasbeyer @vcunat @primeos