Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install postgresql extensions under $out/share/postgresql #64027

Merged
merged 1 commit into from Jul 1, 2019
Merged

Install postgresql extensions under $out/share/postgresql #64027

merged 1 commit into from Jul 1, 2019

Conversation

ehamberg
Copy link
Contributor

@ehamberg ehamberg commented Jul 1, 2019

Move postgresql extensions from $out/share to $out/share/postgresql.

Fixes #63805

Motivation for this change

Fix broken PostgreSQL with extensions after #62271 moved files from $out/share to $out/share/postgresql.

Things done

I have only tested this for TimescaleDB and PostGIS on NixOS.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehamberg
Install postgresql extensions under $out/share/postgresql
80aadbe 
This fixes extensions after #62271 moved files from `$out/share` to
`$out/share/postgresql`.
@ehamberg ehamberg mentioned this pull request Jul 1, 2019
Closed
@coreyoconnor
Copy link
Contributor

LGTM. tho, I have only tested postgis

@matthewbauer matthewbauer merged commit eea3329 into NixOS:master Jul 1, 2019
@matthewbauer
Copy link
Member

Thanks! This was an oversight on my part

@ehamberg ehamberg deleted the fix-postgres-ext-dirs branch July 1, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken PostgreSQL with plugins
3 participants
@ehamberg @coreyoconnor @matthewbauer