Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawio: init at 10.8.0 #64109

Merged
merged 1 commit into from Jul 9, 2019
Merged

drawio: init at 10.8.0 #64109

merged 1 commit into from Jul 9, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 2, 2019

Motivation for this change

draw.io is an application for drawing diagrams. This is the (offline)
desktop version of the draw.io web application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

danieldk commented Jul 2, 2019

@GrahamcOfBorg build drawio

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/derivation-of-draw-io-deb-package-crashes/1027/5

JohnAZoidberg
JohnAZoidberg reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great on NixOS :)
I can create diagrams, save them and load them again.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/23

worldofpeace
worldofpeace suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and comments with how the expression could be more idiomatic

pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/drawio/default.nix Outdated Show resolved Hide resolved
@danieldk danieldk force-pushed the draw.io branch 2 times, most recently from 2c2a698 to 191db48 Compare July 8, 2019 13:51
@danieldk
Copy link
Contributor Author

danieldk commented Jul 8, 2019

@worldofpeace Thanks for all the suggestions! I hope that I have properly addressed them.

@danieldk
drawio: init at 10.8.0
f658a3c 
draw.io is an application for drawing diagrams. This is the (offline)
desktop version of the draw.io web application.
worldofpeace
worldofpeace approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieldk Looks great, works. 👍

@worldofpeace worldofpeace merged commit 5dbce90 into NixOS:master Jul 9, 2019
@danieldk danieldk deleted the draw.io branch July 6, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @nixos-discourse @JohnAZoidberg @worldofpeace