Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lidarr: add user/group/openFirewall opts. #64113

Merged
merged 1 commit into from Jul 5, 2019

Conversation

davidtwco
Copy link
Member

Motivation for this change

This PR adds new configuration options to the Lidarr module that
allows configuration of the user and group that Lidarr runs as; and to
open the firewall for the Lidarr port.

I've checked that this works by importing the module from the branch and
using the options.

cc @etu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This commit adds new configuration options to the Lidarr module that
allows configuration of the user and group that Lidarr runs as; and to
open the firewall for the Lidarr port.
@etu
Copy link
Contributor

etu commented Jul 3, 2019

@GrahamcOfBorg test lidarr

1 similar comment
@etu
Copy link
Contributor

etu commented Jul 4, 2019

@GrahamcOfBorg test lidarr

@etu etu merged commit 8231207 into NixOS:master Jul 5, 2019
@davidtwco davidtwco mentioned this pull request Jul 7, 2019
10 tasks
@davidtwco davidtwco deleted the lidarr/users-groups-firewalls branch July 12, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants