Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubico-piv-tool: support Apple PCSC, enable by default #64114

Merged
merged 1 commit into from Mar 13, 2020

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Users of macOS will typically want to use the Apple provided PCSC. This change makes the yubico-piv-tool work with no additional configuration. Same change in spirit as #60852.

Tested talking to a Yubikey on macOS and NixOS with ./result/bin/yubico-piv-tool -a status

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit 43d1c44 into NixOS:master Mar 13, 2020
@thefloweringash thefloweringash deleted the yubico-piv-tool-mac branch March 13, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants