New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smimesign: init at v0.0.13 #64163
smimesign: init at v0.0.13 #64163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my annotations, this looks pretty good (not tested though).
Thanks @matthiasbeyer for the quick response. I made the requested changes, let me know if there's anything else. |
@GrahamcOfBorg build smimesign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, otherwise looks good. Will merge after this was addressed.
Thanks @kalbasit, I've fetched the latest commits from origin and changed the |
@GrahamcOfBorg build smimesign |
Motivation for this change
Adding GitHub's https://github.com/github/smimesign. Although this is a
darwin
only package, I believe I have found other examples of this and followed their precedent. Let me know if I should move anything around.The commit itself is signed by the binary built by Nix.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)