Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smimesign: init at v0.0.13 #64163

Merged
merged 2 commits into from Jul 4, 2019
Merged

smimesign: init at v0.0.13 #64163

merged 2 commits into from Jul 4, 2019

Conversation

ericnorris
Copy link
Contributor

@ericnorris ericnorris commented Jul 2, 2019

Motivation for this change

Adding GitHub's https://github.com/github/smimesign. Although this is a darwin only package, I believe I have found other examples of this and followed their precedent. Let me know if I should move anything around.

The commit itself is signed by the binary built by Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my annotations, this looks pretty good (not tested though).

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/top-level/darwin-packages.nix Outdated Show resolved Hide resolved
@ericnorris
Copy link
Contributor Author

Thanks @matthiasbeyer for the quick response. I made the requested changes, let me know if there's anything else.

@kalbasit
Copy link
Member

kalbasit commented Jul 4, 2019

@GrahamcOfBorg build smimesign

Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise looks good. Will merge after this was addressed.

pkgs/os-specific/darwin/smimesign/default.nix Outdated Show resolved Hide resolved
@ericnorris
Copy link
Contributor Author

Thanks @kalbasit, I've fetched the latest commits from origin and changed the description field.

@ofborg ofborg bot requested a review from kalbasit July 4, 2019 16:55
@kalbasit
Copy link
Member

kalbasit commented Jul 4, 2019

@GrahamcOfBorg build smimesign

@kalbasit kalbasit merged commit 6a6d115 into NixOS:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants