Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11.settings.libXNVCtrl: set OUTPUTDIR for build #64165

Merged

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 2, 2019

Built linuxPackages_latest.nvidia_x11{,_legacy390}.settings.libXNVCtrl.

Motivation for this change

Closes #64135.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with

nixos-rebuild boot -I nixpkgs=/alt/nixpkgs-channels

after applying the patch to a clone of nixpkgs-channels

@abbradar
Copy link
Member

abbradar commented Jul 3, 2019

Tested by building the package. Thanks!

@abbradar abbradar merged commit 4a79bed into NixOS:master Jul 3, 2019
@eadwu eadwu deleted the nvidia_settings.libXNVCtrl/fix-build-outputdir branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libXNVCtrl fails building on nixos unstable
3 participants