dell/xps/13-9380: also import intel profile #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no AMD as an option: https://www.dell.com/en-uk/shop/laptops-notebooks-and-2-in-1-laptops/xps-13-laptop/spd/xps-13-9380-laptop |
Mic92
commented
Jul 1, 2019
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| { | |||
| imports = [ | |||
| ../../../common/cpu/intel | |||
There was a problem hiding this comment.
Since all of them also have NVME, I wonder if we should have a NVME profile?
There was a problem hiding this comment.
You joined the 9380 fan-base? 😀
Yea I think that's fair to say.
There was a problem hiding this comment.
I was not aware that this is a cult already. The screen is nice. The battery in my old laptop lasted a longer.
There was a problem hiding this comment.
The NVME profile might be worth another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.