Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cleo: 0.7.4 -> 0.7.5 #64222

Merged
merged 2 commits into from Jul 3, 2019
Merged

pythonPackages.cleo: 0.7.4 -> 0.7.5 #64222

merged 2 commits into from Jul 3, 2019

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jul 3, 2019

Motivation for this change

Upgrade cleo andclikit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Resolves #64127.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this build for you on Mac? Because i get:

  ERROR: No matching distribution found for glob2<0.7,>=0.6; python_version >= "2.7" and python_version < "2.8" or python_version >= "3.4" and python_version < "3.5" (from poetry==0.12.16)
cannot build derivation '/nix/store/q4jb91ksf3f2g95jv5cc0cf29yvbd92a-env.drv': 3 dependencies couldn't be built
[4 built (3 failed), 0.0 MiB DL]
error: build of '/nix/store/q4jb91ksf3f2g95jv5cc0cf29yvbd92a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64222
3 package failed to build:
python27Packages.cleo python27Packages.poetry python37Packages.cleo

@jbaum98
Copy link
Contributor Author

jbaum98 commented Jul 3, 2019

It builds for me when I rebase onto #64127. I think I should have note the dependency.

@jonringer
Copy link
Contributor

I would just rebase it on top of #64127, and push both. Then comment that it resolves #64127. Doesn't really make sense to do one without the other :)

@FRidh FRidh merged commit 840b538 into NixOS:master Jul 3, 2019
@jbaum98 jbaum98 deleted the cleo branch July 3, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants