Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ycmd: build with python3 #64219

Merged
merged 2 commits into from Jul 8, 2019
Merged

ycmd: build with python3 #64219

merged 2 commits into from Jul 8, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Should resolve #64048 where nvim and ycmd pythonpaths conflict.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 3, 2019

@GrahamcOfBorg build ycmd

@cstrahan
Copy link
Contributor

cstrahan commented Jul 3, 2019

You'll also need to change this line to use python3 instead of python:

nixpkgs/pkgs/misc/vim-plugins/overrides.nix

Line 420 in 01e07b1

"'ycm_path_to_python_interpreter', '${python}/bin/python'"

@cstrahan
Copy link
Contributor

cstrahan commented Jul 3, 2019

Also, it would seem that YouCompleteMe has changed the name of that variable to ycm_python_interpreter_path, so you'll want to check that the above substitution is actually working -- I think you'll need to change the variable name appropriately.

@ofborg ofborg bot added the 6.topic: vim label Jul 3, 2019
@ofborg ofborg bot requested a review from jagajaga July 3, 2019 14:41
@jonringer
Copy link
Contributor Author

Applied suggestions :)

@cstrahan
Copy link
Contributor

cstrahan commented Jul 8, 2019

Awesome. Sorry it's taken me a while to get back to this, it's been a busy week.

Thanks!

@cstrahan cstrahan merged commit 5ded60d into NixOS:master Jul 8, 2019
@jonringer jonringer deleted the ycmd-python3 branch July 9, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PYTHONPATH handling in neovim breaks YouCompleteMe
3 participants
@jonringer @FRidh @cstrahan