Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonobuoy: init at 0.15.0 #63970

Merged
merged 1 commit into from Jul 23, 2019
Merged

sonobuoy: init at 0.15.0 #63970

merged 1 commit into from Jul 23, 2019

Conversation

carlosdagos
Copy link
Member

@carlosdagos carlosdagos commented Jul 1, 2019 •
edited

Motivation for this change

Neat program to run k8s tests 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@carlosdagos
Copy link
Member Author

Addressed your comments @JohnAZoidberg. Thanks!

@adisbladis
Copy link
Member

@GrahamcOfBorg build sonobuoy

@adisbladis adisbladis merged commit 2e6277f into NixOS:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlosdagos @adisbladis @Lassulus @JohnAZoidberg