Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: init serverless at 1.47.0 and update #64204

Closed
wants to merge 2 commits into from
Closed

nodePackages: init serverless at 1.47.0 and update #64204

wants to merge 2 commits into from

Conversation

malob
Copy link
Member

@malob malob commented Jul 2, 2019

Motivation for this change

I use serverless for a bunch of cloud function development stuff, and would love to be able to easily install it from nixpkgs.

Things done
  • Ran ./generate.sh, and then committed changes (36977d3).
  • Added serverless to node-packages-v10.json, ran ./generate.sh again, and then commited changes (66d9abe).
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your node2nix version and try again, should help cut down on some of the spam.

Also, the title should be nodePackages.serverless: init at 1.46.1 or nodePackages.serverless: init at 1.46.1 and update?(not sure about this one), to help out with knowing what to look for.

pkgs/development/node-packages/composition-v10.nix Outdated
@@ -1,4 +1,4 @@
# This file has been generated by node2nix 1.7.0. Do not edit!
# This file has been generated by node2nix 1.6.0. Do not edit!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind updating your node2nix version and trying again :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! (Issue was that nixpkgs-19.03-darwin doesn't have the latest version.)

@malob malob changed the title Add node package nodePackages.serverless: init at 1.46.1 and update Jul 3, 2019
@malob malob force-pushed the add-node-package branch 2 times, most recently from fff7398 to 410ef06 Compare July 3, 2019 07:38
@malob
Copy link
Member Author

malob commented Jul 3, 2019

Alright this should be good to go (sorry for derping on the PR name).

@malob malob changed the title nodePackages.serverless: init at 1.46.1 and update nodePackages: init serverless at 1.46.1 and update Jul 3, 2019
@jonringer
Copy link
Contributor

You're good, unfortunately I'm not much of a node guy to comment on anything else :)

@malob malob changed the title nodePackages: init serverless at 1.46.1 and update nodePackages: init serverless at 1.47.0 and update Jul 15, 2019
@malob
Copy link
Member Author

malob commented Jul 15, 2019

Updated PR to deal with merge conflicts.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/28

@alyssais alyssais closed this in 279d51e Sep 17, 2019
@malob malob deleted the add-node-package branch September 17, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malob @jonringer @nixos-discourse