Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Numpy on PyPy #64200

Merged
merged 2 commits into from Jul 3, 2019
Merged

Fix Numpy on PyPy #64200

merged 2 commits into from Jul 3, 2019

Conversation

leo60228
Copy link
Member

@leo60228 leo60228 commented Jul 2, 2019

Motivation for this change

Numpy works on PyPy as of October 2017, but tests fail for some of its dependencies. I applied a patch from Gentoo, and disabled tests on Numpy for PyPy (due to Numpy 1.16+ hitting a PyPy bug, which is fixed in both Numpy and PyPy HEAD, but not a release). For some reason most of the dependencies are getting built locally, but this built fine before I rebased it, so I'll check if it builds in the morning.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leo60228 leo60228 requested a review from FRidh as a code owner July 2, 2019 22:47
@leo60228 leo60228 mentioned this pull request Jul 2, 2019
Closed
10 tasks
@FRidh FRidh merged commit f38fbf8 into NixOS:staging Jul 3, 2019
@FRidh
Copy link
Member

FRidh commented Jul 3, 2019

Ah, this could have actually gone to master. Ah, well, now you'll have to be patient ;-)

@veprbl veprbl mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo60228 @FRidh