Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: add fixDarwinDylibNames #64144

Merged
merged 1 commit into from Jul 2, 2019
Merged

arrow-cpp: add fixDarwinDylibNames #64144

merged 1 commit into from Jul 2, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 2, 2019

Motivation for this change

Fixes: #64133

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Jul 2, 2019

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

@veprbl veprbl merged commit f762899 into NixOS:master Jul 2, 2019
veprbl added a commit that referenced this pull request Jul 2, 2019
@veprbl
arrow-cpp: add fixDarwinDylibNames
e6fe2df 
(cherry picked from commit e884852)

cc #64144
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Jul 2, 2019
veprbl added a commit that referenced this pull request Jul 2, 2019
@veprbl
arrow-cpp: add fixDarwinDylibNames
9f9806d 
(cherry picked from commit e884852)

cc #64144
@veprbl veprbl deleted the pr/arrow-cpp_dylib_id_fix branch December 1, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arrow-cpp uses @rpath/libarrow.13.dylib rather than /nix
1 participant
@veprbl