python: wxPython: init at 4.0.6 #64047

tbenst · 2019-07-01T18:53:45Z

Motivation for this change

add wxPython 4, which is unlisted in python-modules and broken.

Things done

Split off from #61253 and addressed comments by @veprbl

Resolves: #55426

tbenst · 2019-07-01T18:56:18Z

also of interest to @deliciouslytyped, sorry for delay!

jonringer

This should build for python2 according to pypi, please try to build that as well

pkgs/development/python-modules/wxPython/4.0.nix

veprbl · 2019-07-02T02:01:16Z

pkgs/development/python-modules/wxPython/4.0.nix

-    gtk3 libjpeg libtiff SDL gst-plugins-base libnotify freeglut xorg.libSM
-    which
-  ];
+  nativeBuildInputs = [ pkgconfig which doxygen wxGTK libX11 ];


Like I said before, wxGTK and libX11 are libraries, so let's move them to buildInputs if they are needed.

@veprbl if I do this, the build fails shrug

The build succeeds if I remove libX11. Moving wxGTK, indeed, fails because it can't find "wx-config", which I don't understand ATM.

Does this still matter? I'm going back to take another shot at enabling tests and I might look into this or add it as an open problem.

It is probably okay now

nixpkgs/pkgs/development/python-modules/wxPython/4.0.nix

Lines 40 to 48 in b1bffdf

nativeBuildInputs = [ pkgconfig which doxygen wxGTK ];

buildInputs = [ libjpeg libtiff SDL

gst-plugins-base libnotify freeglut xorg.libSM ncurses

requests libpng gstreamer libX11

pathlib2

(wxGTK.gtk)

]

++ lib.optional openglSupport pyopengl;

tbenst · 2019-07-02T07:18:42Z

@veprbl @jonringer thx for great comments! I took suggestions as possible, except where it would break the build

FRidh · 2019-07-02T08:33:59Z

pkgs/development/python-modules/wxPython/4.0.nix

+  '';
+
+  buildPhase = ''
+  python build.py -v --use_syswx dox etg --nodoc sip build_py


Please build a wheel using bdist_wheel. The installPhase then won't need to be overridden.

Thanks @FRidh! When I add python build.py bdist_wheel to the end of buildPhase, I get:

File "setup.py", line 15, in <module> from setuptools import setup, find_packages ModuleNotFoundError: No module named 'setuptools'

Per the manual, I tried adding setuptools_scm to nativeBuildInputs and setuptools to propogatedBuildInputs, but the error is unchanged.

The one time I had an error like that I think something was wrong with how PYTHONPATH was set up (determined by comparing the failing version to something else maybe?), but I don't think I spent the time to figure it out.

They are using a custom build system based on waf so I don't think our generic builders will be able to handle this.

I worked on my own version of this PR a while ago, and was able to get bdist_wheel working using this: lopsided98@47786de#diff-5dbc383e8d8890c6c54121d966199558R31

pkgs/top-level/python-packages.nix

deliciouslytyped · 2019-07-26T00:52:22Z

ping?

deliciouslytyped · 2019-07-26T01:09:44Z

pkgs/development/python-modules/wxPython/4.0.nix

-  nativeBuildInputs = [
-    pkgconfig
-  ];
+  doCheck = false;


Why? I haven't tried it yet, just asking.

pkgs/development/python-modules/wxPython/4.0.nix

deliciouslytyped · 2019-07-26T01:11:40Z

pkgs/development/python-modules/wxPython/4.0.nix

+  '';
+
+  installPhase = ''
+    ${python.interpreter} setup.py install --skip-build --prefix=$out


This uses python.interpreter but buildPhase just calls python? Why the difference?
I don't know what this does offhand but maybe this has something to do with the setuptools error? (or maybe not)

In our generic builder we use a following:

nixpkgs/pkgs/development/interpreters/python/build-python-package-setuptools.nix

Line 33 in fd2b2b5

${python.pythonForBuild.interpreter} nix_run_setup ${setupPyGlobalFlagsString} ${setupPyBuildExtString} bdist_wheel

deliciouslytyped · 2019-07-26T01:33:45Z

pkgs/development/python-modules/wxPython/4.0.nix

+    wrapPythonPrograms
+  '';
+
+  passthru = { inherit wxGTK openglSupport; };


Also copied from https://github.com/NixOS/nixpkgs/blob/3c6ec09222efe40461a5536e5df26f3e7031ae04/pkgs/development/python-modules/wxPython/3.0.nix

deliciouslytyped · 2019-07-28T16:41:30Z

@veprbl I'm trying to enable tests but working on it is really frustrating when a failure in the test phase fails the whole derivation and I have to wait an hour for the next cycle. Is there any way to separate tests and the build into separate derivations?

Edit: meanwhile I worked around this by using nix-shell.

lopsided98

I worked on my own version of this PR a while ago but hadn't gotten around to submitting it. Overall, this PR seems better (it doesn't rely on wx-config and builds the documentation), but there might a few parts of my version that you could use.

lopsided98 · 2019-07-28T17:01:37Z

pkgs/top-level/python-packages.nix

@@ -4660,6 +4660,11 @@ in {
    inherit (pkgs) pkgconfig;
  };

+  wxPython_4_0 = callPackage ../development/python-modules/wxPython/4.0.nix {


I think this should either follow the naming convention of wxPython30, or wxPython30 should be renamed (with an alias for compatibility).

Also, since wxPython 3.0 does not support Python 3, we might want to make the wxPython package point to 4.0 on Python 3. Even if some packages aren't compatible, it seems better than having every package that uses wxPython fail to evaluate on Python 3.

Is WxPython 4 API compatible with 3?
Edit: I suppose python 3 apps wont have been coded to use wxpython 3 anyway though because there was no support for wxpython in python 3 before... I think what I was trying to say is: is incompatibility even a thing?

They are not fully API compatible. Any application that wants to target both Python 2 and 3 is probably going to use wxPython 4.0, but it might be possible to be compatible with both 3.0 and 4.0.

Making 4.0 the default for Python 3 will only make packages that currently fail to evaluate, fail to build.

@lopsided98 see #64047 (comment)

I agree re pointing wxPython to 4.0 for python3..do you know how to do this? I’m familiar with overrides but not with how to do this in nixpkgs

lopsided98 · 2019-07-28T17:05:51Z

pkgs/development/python-modules/wxPython/4.0.nix

+  '';
+
+  buildPhase = ''
+  python build.py -v --use_syswx dox etg --nodoc sip build_py


I worked on my own version of this PR a while ago, and was able to get bdist_wheel working using this: lopsided98@47786de#diff-5dbc383e8d8890c6c54121d966199558R31

deliciouslytyped · 2019-07-28T18:27:05Z

@lopsided I can't reply to your post for some reason but the original buildPhase has similar code to that

nixpkgs/pkgs/development/interpreters/python/build-python-package-setuptools.nix

Line 32 in d3433f7

cp ${setuppy} nix_run_setup

(which I assume you based off of) so...kind of a bad phase override (or this stuff didn't exist at the time?).

jonringer · 2019-07-28T19:31:11Z

@veprbl I'm trying to enable tests but working on it is really frustrating when a failure in the test phase fails the whole derivation and I have to wait an hour for the next cycle.

nix-shell ./path/to/nixpkgs/default.nix -A pythonPackage.wxPython will probably your best bet, you will be loaded into a similar environment as when the package builds, I don't remember if checkInputs all get inserted. If you have the source checked out locally, then you can iterate within that shell.

Edit: meanwhile I worked around this by using nix-shell.

Was just making sure :)

Another option would be to make 2 derivations, one for the building the initial package, then another that imports that package and runs the tests

lopsided98 · 2019-07-28T19:32:43Z

@lopsided I can't reply to your post for some reason but the original buildPhase has similar code to that

Yes, I adapted mine from that.

deliciouslytyped · 2019-07-28T19:41:03Z

It annoys me that you had to duplicate the code like that but I don't know what to do about it. :(
Meanwhile I had some trouble figuring out how the heck to run the unit tests. Maybe we should try to document somewhere that if anyone is trying to find something related to the build system they should look in build.py... (I completely forgot about that since the last time I poked at this)

deliciouslytyped · 2019-07-28T19:45:08Z

It appears to me that build.py does some stuff for calling python itself, for running tests - this may be dropping/mangling PYTHONPATH or whatever the nix infrastructure does. This may need to be worked around to get tests to function.

It might be good to get some wxPython people to review our stuff at some point?

Edit:
Temporary workaround: patch to the following:
os.environ['PYTHONPATH'] = os.environ['PYTHONPATH']+ ":" + phoenixDir()
Will ask upstream to patch.

deliciouslytyped · 2019-07-28T21:45:02Z

@jonringer Thanks, I totally missed your comment. I was thinking about making two derivations like you said but I thought of how to do it with nix-shell faster than otherwise. Now that I actually know how to run the tests I might try the latter though.

Currently stuck on /nix/store/dwi186iqm6p3kfncfsl62fbfwfry1yci-python3-3.7.3/bin/python3.7: can't open file 'nix_run_setup': [Errno 2] No such file or directory in nix-build, but maybe more on that later.
...Which might be exactly what @lopsided98 worked around as discussed above...

deliciouslytyped · 2019-07-28T21:49:46Z

However, I don't understand why that would be the case given that both buildPhase and installCheckPhase (in my WIP) are overridden, so nothing should be trying to call nix_run_setup...

jonringer · 2019-07-29T02:57:21Z

@deliciouslytyped your installCheckPhases are being overriden most likely because you're using a buildPythonPackage which will override those attrs here or a related build helper.

/nix/store/dwi186iqm6p3kfncfsl62fbfwfry1yci-python3-3.7.3/bin/python3.7: can't open file 'nix_run_setup'

This will happen if you override the buildPhase, but use the default checkPhase. If you're using installCheckPhase, i would move it to checkPhase. Or even better yet, try to use the preCheck, and postCheck hooks if it fits your problem domain.

deliciouslytyped · 2019-07-29T03:02:49Z

Doh, the order on the // there caught me with my pants down! (I assumed...) Looks like I need some more belts...

Seems a bit unorthodox that they go and override that...
Hmm, interesting, maybe that's a way to do it without using removeAttrs.
I'm too tired at this point to figure out if what I'm saying is coherent, so that's that for today.

jonringer · 2019-07-29T15:40:36Z

@deliciouslytyped for the average python package, this behavior makes sense. The typical "build and install"for python is just dumping .py's into a directory. If you do need all the phases and "more" control, you could do stdenv.mkderivation + toPythonModule however, this is generally more aimed at projects that have a significant amount of native build outputs and the project stands on it's own outside of python; the toPythonModule will just package the bindings, IIRC.

deliciouslytyped · 2019-07-29T18:05:36Z

Edit: see also: https://github.com/wxWidgets/Phoenix/pull/1135/files for test thingy usage example

WIP, has tests at least running:

{ openglSupport ? true

, lib
, stdenv

, buildPythonPackage
, fetchPypi
, python
, pyopengl

, wxGTK
, cairo
, pango

#nativeBuildInputs
, which
, doxygen
, pkgconfig

#buildInputs
, libjpeg
, libtiff
, SDL
, gst-plugins-base
, libnotify
, freeglut
, xorg
, ncurses
, requests
, libpng
, gstreamer
, libX11
, pathlib2

#checkInputs #TODO clean
, numpy
, pytest, pytest_xdist, pytest-timeout
, sphinx
, xvfb_run
}@args:

let
  pname = "wxPython";
  version = "4.0.6";
in

buildPythonPackage rec {
  inherit pname version;

  src = fetchPypi {
    inherit pname version;
    sha256 = "35cc8ae9dd5246e2c9861bb796026bbcb9fb083e4d49650f776622171ecdab37";
    };

  checkInputs = [ xvfb_run sphinx numpy pytest pytest_xdist pytest-timeout ];
  disabledTests = [
    "access_Tests"  #TODO because not implemented yet and automatically fails
    "test_lib_agw_piectrlMethods"  #TODO because hangs the build and timeout skips the rest of tests
    ];
  checkPhase = ''
    runHook preCheck
    xvfb-run -s '-screen 0 800x600x24' \
      ${python.pythonForBuild.interpreter} build.py test --verbose --pytest_timeout=60 \
         --extra_pytest="-k 'not ( ${lib.concatStringsSep " or " disabledTests} )'"
    runHook postCheck
    '';

  nativeBuildInputs = [ pkgconfig which doxygen wxGTK ];

  buildInputs = [
    libjpeg libtiff SDL
    gst-plugins-base libnotify freeglut xorg.libSM ncurses
    requests libpng gstreamer libX11
    pathlib2
    (wxGTK.gtk)
    ] ++ (lib.optional openglSupport pyopengl);

  hardeningDisable = [ "format" ];
  
  DOXYGEN = "${doxygen}/bin/doxygen";

  preConfigure = lib.optionalString (!stdenv.isDarwin) ''
    substituteInPlace wx/lib/wxcairo/wx_pycairo.py \
      --replace 'cairoLib = None' 'cairoLib = ctypes.CDLL("${cairo}/lib/libcairo.so")'
    substituteInPlace wx/lib/wxcairo/wx_pycairo.py \
      --replace '_dlls = dict()' '_dlls = {k: ctypes.CDLL(v) for k, v in [
        ("gdk",        "${wxGTK.gtk}/lib/libgtk-x11-2.0.so"),
        ("pangocairo", "${pango.out}/lib/libpangocairo-1.0.so"), #TODO does this need to refer to .out
        ("appsvc",     None)
        ]}'
    '';

  prePatch = ''
    substituteInPlace build.py \
      --replace "os.environ['PYTHONPATH'] = phoenixDir()" "os.environ['PYTHONPATH'] = os.environ['PYTHONPATH'] + ':' + phoenixDir()"
    '';

  buildPhase = ''
    python build.py -v --use_syswx dox etg --nodoc sip build_py
    '';

  installPhase = ''
    ${python.interpreter} setup.py install --skip-build --prefix=$out #TODO this uses python.interpreter but the above does not?
    wrapPythonPrograms
    '';

  passthru = { inherit args; };

  meta = {
    description = "Cross platform GUI toolkit for Python, Phoenix version";
    homepage = http://wxpython.org/;
    license = lib.licenses.wxWindows;
    };

  }

deliciouslytyped · 2019-07-29T18:27:37Z

Something looks sketchy here:

unittests/test_lib_agw_piectrl.py::lib_agw_piectrl_Tests::test_lib_agw_piectrlCtor PASSED [ 44%]
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/nix/store/9pl2hgg3p2ijhzaycj2h77p3ny0vwfgy-python3.7-pytest-4.2.1/lib/python3.7/site-packages/_pytest/main.py", line 203, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/nix/store/9pl2hgg3p2ijhzaycj2h77p3ny0vwfgy-python3.7-pytest-4.2.1/lib/python3.7/site-packages/_pytest/main.py", line 243, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)

[SNIP]

INTERNALERROR>     pytest.fail('Timeout >%ss' % timeout)
INTERNALERROR>   File "/nix/store/9pl2hgg3p2ijhzaycj2h77p3ny0vwfgy-python3.7-pytest-4.2.1/lib/python3.7/site-packages/_pytest/outcomes.py", line 113, in fail
INTERNALERROR>     raise Failed(msg=msg, pytrace=pytrace)
INTERNALERROR> Failed: Timeout >60.0s

== 19 failed, 754 passed, 6 skipped, 1 xfailed, 68 warnings in 524.68 seconds ==

Does it just abort the rest of the test process on a timeout? Note the last PASSED is at 44%.

Edit: The help string does say "Timeout, in seconds, for stopping stuck test cases. (Currently not working as expected, so disabled by default.)"

tbenst · 2019-07-31T01:53:32Z

@deliciouslytyped thanks for picking up, been offline in the wilderness. Will try to look at tests in a couple days, they are a real PITA which is why I disabled doCheck. I did try some applications though, like Helloworld, that worked fine.

nixos-discourse · 2019-07-31T13:18:52Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/wxpython-on-python3/3588/2

deliciouslytyped · 2019-07-31T16:57:54Z

Test termination behavior of timeout is explained at https://pypi.org/project/pytest-timeout/

deliciouslytyped · 2019-07-31T16:59:35Z

@FRidh stuff seems to generally work, how should failing tests be handled? It would be nice to get this merged finally...

I'm also not sure how to process test ouput.

deliciouslytyped · 2019-08-02T00:00:23Z

pkgs/top-level/python-packages.nix

@@ -4660,6 +4660,11 @@ in {
    inherit (pkgs) pkgconfig;
  };

+  wxPython_4_0 = callPackage ../development/python-modules/wxPython/4.0.nix {
+    inherit (pkgs) pkgconfig;


Why? (Well ok this isn't specific to this PR)

The reason why we need to explicitly pass things from pkgs is because the callPackage defined in python-packages.nix

nixpkgs/pkgs/top-level/python-packages.nix

Line 23 in b9a7c07

callPackage = pkgs.newScope self;

will only substitute arguments from self (aka pythonPackages) and not from pkgs.

pythonPackages seems to have its own pkgconfig attribute too somehow? Meanwhile pkgs has pkg-config... (or I got mixed up somewhere)

Ok so pkgs has a pkgconfig and a pkg-config, and pyhtonPackages has a pkgconfig.

Okay, so my explanation was wrong. The callPackage will also substitute arguments from pkgs, but self (pythonPackages) takes priority. And, indeed we already have pkgconfig attribute in pythonPackages, but we don't want to get the "pkgconfig" python package, we want just the regular pkgconfig. And this is why we need to explicitly state that it must come from pkgs.

Correct, you should be able to import something like "tree", even though it doesnt exist in top-level/python-modules.nix, because it inherits from pkgs. However, if you do something like "docker" you'll get pythonPackages.docker instead of ./nixpkgs -A docker due to how callPackage prioritizes overlapping attrs.

jonringer · 2019-08-02T02:29:38Z

@deliciouslytyped you can use the pytest testrunner, it has more options to disabling certain tests or files.

pytest --ignore=path/to/file.py or -k 'not some_test_substring'

example can be seen here 93ebc61

deliciouslytyped · 2019-08-10T03:00:21Z

@FRidh can you please set some minumum criteria for getting this merged so I have something to work towards?
We can set some additional goals for after that, I would really like this to just be in the tree already.

deliciouslytyped · 2019-08-18T11:12:49Z

Can/should we do anything about using wrapgappshook here? or does that need to be used in the libraries/binaries that consume this package?

FRidh · 2019-08-18T11:43:53Z

I made a change and pushed to master. Thanks for the effort. In the future, though, we should improve this to build a wheel instead.

deliciouslytyped · 2019-08-18T11:46:14Z

Yay, since this PR is closed, I should probably create a TODO list in a new issue "soon".

deliciouslytyped · 2019-08-18T11:49:38Z

What did you change?

FRidh · 2019-08-18T11:50:45Z

Using ${python.interpreter} instead of python

deliciouslytyped · 2019-12-16T14:09:18Z

I'm not volunteering right now but does anyone want to work on getting tests enabled and following up with upstream about the tests?

tbenst requested a review from FRidh as a code owner July 1, 2019 18:53

ofborg bot added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 1, 2019

jonringer reviewed Jul 2, 2019

View reviewed changes

veprbl reviewed Jul 2, 2019

View reviewed changes

tbenst force-pushed the wxPython branch 2 times, most recently from 85dfa10 to deaf7e3 Compare July 2, 2019 07:18

FRidh reviewed Jul 2, 2019

View reviewed changes

veprbl reviewed Jul 2, 2019

View reviewed changes

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved

python: wxPython: init at 4.0.6

3c6ec09

tbenst force-pushed the wxPython branch from deaf7e3 to 3c6ec09 Compare July 2, 2019 20:21

deliciouslytyped reviewed Jul 26, 2019

View reviewed changes

pkgs/development/python-modules/wxPython/4.0.nix Show resolved Hide resolved

deliciouslytyped reviewed Jul 26, 2019

View reviewed changes

lopsided98 suggested changes Jul 28, 2019

View reviewed changes

deliciouslytyped mentioned this pull request Jul 28, 2019

NixOS packaging misc. wxWidgets/Phoenix#1314

Open

FRidh self-assigned this Jul 29, 2019

deliciouslytyped mentioned this pull request Jul 29, 2019

Tests behaving strangely with timeout wxWidgets/Phoenix#1316

Open

deliciouslytyped reviewed Aug 2, 2019

View reviewed changes

FRidh added this to the 19.09 milestone Aug 18, 2019

FRidh closed this Aug 18, 2019

tbenst deleted the wxPython branch August 18, 2019 22:37

tbenst mentioned this pull request Oct 31, 2019

python3packages.stytra: init at 0.8.26 #72353

Merged

10 tasks

deliciouslytyped mentioned this pull request Dec 16, 2019

Enable tests for wxPython40 #75759

Open

FRidh mentioned this pull request Mar 29, 2020

wxPython-4.0 expression is not used #54235

Closed

veprbl mentioned this pull request Mar 30, 2020

cupy: Move cudatoolkit to propagatedNativeBuildInputs to fix Thrust #77708

Draft

10 tasks

evils mentioned this pull request Jun 17, 2020

issue collection/overview of wxWidgets, wxGTK, wxPython (Phoenix), wxmac #90654

Open

	nativeBuildInputs = [ pkgconfig which doxygen wxGTK ];

	buildInputs = [ libjpeg libtiff SDL
	gst-plugins-base libnotify freeglut xorg.libSM ncurses
	requests libpng gstreamer libX11
	pathlib2
	(wxGTK.gtk)
	]
	++ lib.optional openglSupport pyopengl;

python: wxPython: init at 4.0.6 #64047

python: wxPython: init at 4.0.6 #64047

Conversation

tbenst commented Jul 1, 2019 • edited by veprbl

Motivation for this change

Things done

tbenst commented Jul 1, 2019

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tbenst commented Jul 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deliciouslytyped commented Jul 26, 2019

deliciouslytyped Jul 26, 2019 • edited

Choose a reason for hiding this comment

deliciouslytyped Jul 26, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deliciouslytyped commented Jul 28, 2019 • edited

lopsided98 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deliciouslytyped Jul 28, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deliciouslytyped commented Jul 28, 2019 • edited

jonringer commented Jul 28, 2019 • edited

lopsided98 commented Jul 28, 2019

deliciouslytyped commented Jul 28, 2019 • edited

deliciouslytyped commented Jul 28, 2019 • edited

deliciouslytyped commented Jul 28, 2019 • edited

deliciouslytyped commented Jul 28, 2019

jonringer commented Jul 29, 2019

deliciouslytyped commented Jul 29, 2019 • edited

jonringer commented Jul 29, 2019

deliciouslytyped commented Jul 29, 2019 • edited

deliciouslytyped commented Jul 29, 2019 • edited

tbenst commented Jul 31, 2019

nixos-discourse commented Jul 31, 2019

deliciouslytyped commented Jul 31, 2019

deliciouslytyped commented Jul 31, 2019 • edited

deliciouslytyped Aug 2, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer Aug 2, 2019 • edited

Choose a reason for hiding this comment

jonringer commented Aug 2, 2019

deliciouslytyped commented Aug 10, 2019 • edited

deliciouslytyped commented Aug 18, 2019

FRidh commented Aug 18, 2019

deliciouslytyped commented Aug 18, 2019

deliciouslytyped commented Aug 18, 2019

FRidh commented Aug 18, 2019

deliciouslytyped commented Dec 16, 2019

tbenst commented Jul 1, 2019 •

edited by veprbl

deliciouslytyped Jul 26, 2019 •

edited

deliciouslytyped Jul 26, 2019 •

edited

deliciouslytyped commented Jul 28, 2019 •

edited

deliciouslytyped Jul 28, 2019 •

edited

deliciouslytyped commented Jul 28, 2019 •

edited

jonringer commented Jul 28, 2019 •

edited

deliciouslytyped commented Jul 28, 2019 •

edited

deliciouslytyped commented Jul 28, 2019 •

edited

deliciouslytyped commented Jul 28, 2019 •

edited

deliciouslytyped commented Jul 29, 2019 •

edited

deliciouslytyped commented Jul 29, 2019 •

edited

deliciouslytyped commented Jul 29, 2019 •

edited

deliciouslytyped commented Jul 31, 2019 •

edited

deliciouslytyped Aug 2, 2019 •

edited

jonringer Aug 2, 2019 •

edited

deliciouslytyped commented Aug 10, 2019 •

edited