Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wla-dx: git-2017-06-05 -> 9.8 #64233

Merged
merged 1 commit into from Jul 3, 2019
Merged

wla-dx: git-2017-06-05 -> 9.8 #64233

merged 1 commit into from Jul 3, 2019

Conversation

solson
Copy link
Member

@solson solson commented Jul 3, 2019

Upgrade from an old pinned git commit to the latest official stable release. Additionally, the hardeningDisable is no longer required to successfully build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@solson
wla-dx: git-2017-06-05 -> 9.8
cea419a 
Additionally, the `hardeningDisable` is no longer required to
successfully build.
@solson solson mentioned this pull request Jul 3, 2019
Closed
10 tasks
@ofborg ofborg bot requested a review from matthewbauer July 3, 2019 05:26
@matthewbauer matthewbauer merged commit d505283 into NixOS:master Jul 3, 2019
@solson solson deleted the wla-dx-9.8 branch July 4, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solson @matthewbauer