Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeclipse: fix license info #64228

Merged
merged 1 commit into from Jul 3, 2019
Merged

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Got tired of seeing output similar to this:

$ nix-env -f /home/jon/.cache/nix-review/pr-64225/nixpkgs -qaP --xml --out-path --show-trace --meta
derivation 'redeclipse-1.6.0' has invalid meta attribute 'license'

the zlib listed in the license array is getting inherited from the parent scope (the zlib derviation) rather than the license. Looked up zlib license through license attr set to make it unambiguous.

Also quoted url while i was at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/8grwyzf9fxar54a12rdxzrr9fsnjfazz-redeclipse-1.6.0 1.2G

@Lassulus Lassulus merged commit bb7a367 into NixOS:master Jul 3, 2019
@jonringer jonringer deleted the redeclipse-fix-meta branch July 9, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants