Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yder: init at 1.4.5 #64156

Merged
merged 4 commits into from Jul 5, 2019
Merged

yder: init at 1.4.5 #64156

merged 4 commits into from Jul 5, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Is in lots of other repos: https://repology.org/project/yder/versions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested compilation of all library files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/libraries/orcania/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/yder/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/yder/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member Author

What about this?
We can build it without systemd on non-linux. :)

@markuskowa
Copy link
Member

markuskowa commented Jul 4, 2019

@GrahamcOfBorg build yder

@markuskowa
Copy link
Member

What about this?
We can build it without systemd on non-linux. :)

Good idea. Unfortunately it fails to build on darwin.

@JohnAZoidberg
Copy link
Member Author

Let's hope this fixes it :D
@GrahamcOfBorg build yder

@JohnAZoidberg
Copy link
Member Author

Oh, can you please have ofBorg run it on Darwin? @markuskowa
I'm not a privileged user so it doesn't build there.

@markuskowa
Copy link
Member

Still fails on darwin.

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Jul 4, 2019

Yes, still fails, but now during linking the test executable:

[100%] Linking C executable yder_test
/nix/store/37786hp65ar94pkml5yv40xa6gmjbkx0-cmake-3.13.4/bin/cmake -E cmake_link_script CMakeFiles/yder_test.dir/link.txt --verbose=y
/nix/store/2p5k5g7byv3vnswwlj5gramgrh31zdgm-clang-wrapper-7.1.0/bin/clang  -Wall -Werror -O3 -DNDEBUG -arch x86_64 -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/yder_test.dir/test/yder_test.c.o  -o yder_test libyder.1.4.6.dylib /nix/store/ggyq1118bh543dxzfab1bfd1d6zvs626-orcania-2.0.0/lib/liborcania.dylib /nix/store/lv0sjs2f6i3hidphrb2ijnzx1hjm0wwr-check-0.12.0/lib/libcheck.dylib /nix/store/7jmka06vi7mjsgg9i50lgw649azixb8m-subunit-1.1.0/lib/libsubunit.dylib -lm -lrt
ld: library not found for -lrt

My new patch might fix it.

@JohnAZoidberg
Copy link
Member Author

Alright, I think I'm close. (Thanks for rebuilding :))

    Start 1: yder_test
1/1 Test #1: yder_test ........................Child aborted***Exception:   0.00 sec
dyld: Library not loaded: libyder.1.4.dylib
  Referenced from: /tmp/nix-build-yder-1.4.6.drv-0/source/build/yder_test
  Reason: image not found
0% tests passed, 1 tests failed out of 1

Don't know why it works on Linux but not all libraries are linked to the test binary.

@markuskowa
Copy link
Member

Still the same problem.

@JohnAZoidberg
Copy link
Member Author

Even more fixes:

  • Test for journald logging is not systemd specific and fails on darwin
  • If the working directory is different from the build directory, the
    dynamic linker can't find libyder

@markuskowa
Copy link
Member

You're sure you don't want to restrict it to Linux only? Without a mac it is pretty hard to test. In the end we might make it compile but that is no guarantee that it also runs reliably.

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Jul 4, 2019

Yeah, you've got a point. But I'm so close ;) Got all the linker errors fixed and now only the test is remaining. I think I fixed that now.

I'll split my fixes and upstream those patches ASAP.
When it at least builds on darwin, other people can provide upstream with feedback whether it reliably works. Maybe even Nix on Darwin users.

@markuskowa
Copy link
Member

Looks like it works now.

@markuskowa markuskowa merged commit 51aa3cc into NixOS:master Jul 5, 2019
@JohnAZoidberg JohnAZoidberg deleted the yder branch July 5, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants