Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sccache: 0.2.8 -> 0.2.9 #64038

Merged
merged 1 commit into from Jul 5, 2019
Merged

sccache: 0.2.8 -> 0.2.9 #64038

merged 1 commit into from Jul 5, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" - non depend
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ivan
Copy link
Member

ivan commented Jul 4, 2019

@GrahamcOfBorg build sccache

ivan
ivan approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally on x86_64 NixOS master, rustc builds with an empty or populated cache are working fine.

@dywedir
Copy link
Member

dywedir commented Jul 5, 2019

Let's check darwin build
@GrahamcOfBorg build sccache

@dywedir
Copy link
Member

dywedir commented Jul 5, 2019

Thanks!

@dywedir dywedir merged commit 9dcabaf into NixOS:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @ivan @dywedir