Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knot-resolver: fix LUA_{PATH,CPATH} #64174

Closed
wants to merge 1 commit into from
Closed

knot-resolver: fix LUA_{PATH,CPATH} #64174

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 2, 2019

LUA_PATH and LUA_CPATH were both blank beforehand.

Motivation for this change

Enabling DNSSEC, trust_anchors.add_file('/var/cache/kresd/root.keys').

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jul 2, 2019 •
edited

Hmm, I suppose some lua infra changes have broken this. I'll have a closer look later.

BTW, you don't need to add custom root trust anchor file or explicitly enable DNSSEC validation – you get all that by default without these extra lua packages (via dns-root-data package, as the root TA rotates extremely slowly anyway).

@vcunat vcunat self-assigned this Jul 2, 2019
@vcunat vcunat mentioned this pull request Jul 5, 2019
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Jul 5, 2019

This was broken by #63108. Unfortunately this PR isn't a full fix, because it doesn't address dependency propagation, in particular some lua dependencies of http are missing.

teto
teto requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix the original issue. A quickfix might be to use a lua.withPackages as a buildInput ?

@vcunat
Copy link
Member

vcunat commented Jul 5, 2019

Thanks a lot for reporting this! I pushed a quick-fix in the meantime, and I agree we need to resolve the underlying issue anyway.

@vcunat vcunat closed this Jul 5, 2019
peti pushed a commit to peti/nixpkgs that referenced this pull request Jul 5, 2019
@vcunat
knot-resolver: hotfix for a recent $LUA_PATH regression
f0d2da4 
I hope I got all the transitive dependencies.
The 'http' module load again, at least.
Close NixOS#64174
@eadwu eadwu deleted the knot-resolver/fix-lua-path branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto requested changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @vcunat @teto