Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plata-theme: 0.8.3 -> 0.8.7 #64186

Merged
merged 1 commit into from Jul 21, 2019
Merged

plata-theme: 0.8.3 -> 0.8.7 #64186

merged 1 commit into from Jul 21, 2019

Conversation

tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Jul 2, 2019

Motivation for this change

Update plata-theme to 0.8.7.

Reintroduce the mateSupport option, which requires mate.marco and gtk3 for building. This defaults to true to mirror the upstream defaults.

Replace gnome2.glib argument with glib to fix evaluation when allowAliases = false, letting r-ryantm update the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@FRidh
Copy link
Member

FRidh commented Jul 5, 2019

Why is this option added back and why was it removed in the first place?

@tadfisher
Copy link
Contributor Author

@FRidh The enable-mate configure flag was removed upstream, then added back in 0.8.6.

Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some considerations about optional dependencies...

pkgs/data/themes/plata/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/37

@romildo romildo self-requested a review July 21, 2019 02:40
@romildo romildo merged commit a835adc into NixOS:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants