Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rednotebook: 2.8 -> 2.11.1 #64189

Merged
merged 2 commits into from Aug 3, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jul 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rednotebook/versions.

meta.description for rednotebook is: '"A modern journal that includes a calendar navigation, customizable templates, export functionality and word clouds"'.

meta.homepage for rednotebook is: '"http://rednotebook.sourceforge.net/"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
rednotebook

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yisdgnnpdz3lzh3611v7w2g8mygv1xmm-rednotebook-2.11.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A rednotebook https://github.com/r-ryantm/nixpkgs/archive/63445c00d415f6b87a37e03928d98253e965076b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yisdgnnpdz3lzh3611v7w2g8mygv1xmm-rednotebook-2.11.1
ls -la /nix/store/yisdgnnpdz3lzh3611v7w2g8mygv1xmm-rednotebook-2.11.1/bin

cc @orivej for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/rednotebook/versions
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@mmahut
Copy link
Member

mmahut commented Jul 5, 2019

It's missing the journal module upon execution.

Traceback (most recent call last):
  File "/nix/store/wp06mrdzjbmiyxvz5m2rrsmf6h8zapv4-rednotebook-2.11.1/bin/.rednotebook-wrapped", line 7, in <module>
    import journal
ModuleNotFoundError: No module named 'journal'

@orivej
Copy link
Contributor

orivej commented Jul 25, 2019

The import journal error is expected as it comes from this:

try:
    # Load module from same directory
    import journal
    print('Starting RedNotebook from the source directory')
    journal.main()
except ImportError:
    # Load installed module
    import rednotebook.journal
    rednotebook.journal.main()

The actual error (also present in the current version 2.8) is:

Traceback (most recent call last):
  File "rednotebook-2.8/bin/.rednotebook-wrapped", line 12, in <module>
    import rednotebook.journal
  File "rednotebook-2.8/lib/python3.7/site-packages/rednotebook/journal.py", line 43, in <module>
    gi.require_version("Gtk", "3.0")
  File "python3.7-pygobject-3.32.1/lib/python3.7/site-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available

It happens because Gtk was not added to GI_TYPELIB_PATH. gobject-introspection did not add it because it only looks at the packages at the hostOffset. (It had looked at gtk3 before, but cross-compilation support must have been improved.) I have fixed this by moving gobject-introspection from nativeBuildInputs to buildInputs in the additional commit to this PR: 066c08b .

@orivej
Copy link
Contributor

orivej commented Jul 26, 2019

@jtojnar, my fix will break if make_gobject_introspection_find_gir_files is moved to $targetOffset (#56943 (comment)). Should I list gobject-introspection in both nativeBuildInputs and buildInputs, or just disable strictDeps?

gobject-introspection setup hook looks at the packages at $hostOffset to
populate GI_TYPELIB_PATH. We need gtk3 to be there.
@orivej
Copy link
Contributor

orivej commented Aug 3, 2019

I have decided to disable strictDeps until gobject-introspection in nativeBuildInputs is supported .

@orivej-nixos orivej-nixos merged commit 886176e into NixOS:master Aug 3, 2019
@r-ryantm r-ryantm deleted the auto-update/rednotebook branch August 17, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants