Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord-canary: 0.0.84 -> 0.0.85 #64095

Closed
wants to merge 1 commit into from
Closed

discord-canary: 0.0.84 -> 0.0.85 #64095

wants to merge 1 commit into from

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Getting an error when starting this, hence the WIP:

DiscordCanary 0.0.85
(node:9630) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
Starting app.
Removing old directory  0.0.84
Another instance exists. Quitting.
/nix/store/j24zhd4x0sfzw2593b39ad0dqkf185ib-discord-canary-0.0.85/opt/DiscordCanary[9630]: ../../third_party/electron_node/src/node_platform.cc:435:std::shared_ptr<PerIsolatePlatformData> node::NodePlatform::ForIsolate(v8::Isolate *): Assertion `data' failed.
[1]    9630 abort      discord

@tadeokondrak
Copy link
Member Author

Turns out that was just an unlucky random bug, it seems to start up fine after that.

Note that with Discord, the old versions no longer work once an update has been released, so merging this quickly would be nice.

@tadeokondrak tadeokondrak marked this pull request as ready for review July 2, 2019 03:46
@MP2E
Copy link

MP2E commented Jul 2, 2019

Agreed, given this is a minor version bump and that old versions become unusable without warning, I will merge immediately.

@MP2E
Copy link

MP2E commented Jul 2, 2019

merged as of e2a407b

wouldn't let me automerge so I just did it manually

@MP2E MP2E closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadeokondrak @MP2E