Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snscrape: 0.2.0 -> 0.3.0 #64054

Merged
merged 1 commit into from Aug 16, 2019
Merged

snscrape: 0.2.0 -> 0.3.0 #64054

merged 1 commit into from Aug 16, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jul 1, 2019

Motivation for this change

https://github.com/JustAnotherArchivist/snscrape/commits/v0.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested 0.3.0 on twitter and instagram and it worked, unlike 0.2.0 now.

@ivan ivan requested a review from FRidh as a code owner July 1, 2019 20:07
@ivan
Copy link
Member Author

ivan commented Jul 1, 2019

@GrahamcOfBorg build snscrape

@ivan
Copy link
Member Author

ivan commented Jul 27, 2019

@GrahamcOfBorg build snscrape

@grahamc grahamc merged commit 332a46b into NixOS:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants