Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete build-node-package.nix #64056

Merged
merged 1 commit into from Jul 31, 2019
Merged

Delete build-node-package.nix #64056

merged 1 commit into from Jul 31, 2019

Conversation

cdyson37
Copy link
Contributor

@cdyson37 cdyson37 commented Jul 1, 2019

I think this file was orphaned in in daf76db4a57 "top-level: get rid of npm2nix build". I only noticed because it looked quite interesting and I couldn't find a way to use it!

Motivation for this change

File is orphaned. Used to be referenced by pkgs/top-level/node-packages-generated.nix (which is itself deleted).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdyson37
Delete build-node-package.nix
b068f0b 
I think this file was orphaned in in `daf76db4a57` "top-level: get rid of npm2nix build". I only noticed because it looked quite interesting and I couldn't find a way to use it!
@worldofpeace worldofpeace merged commit 02c3557 into NixOS:master Jul 31, 2019
@worldofpeace
Copy link
Contributor

Thanks for cleaning up the tree @cdyson37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdyson37 @worldofpeace