Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.werkzeug: 0.14.1 -> 0.15.1 #58179

Merged
merged 2 commits into from Apr 2, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 23, 2019

Motivation for this change

fixes #33093

Does this warrant a backport?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @samdroid-apps @teozkr

@dotlambda
Copy link
Member Author

@GrahamcOfBorg eval

@GrahamcOfBorg build python2.pkgs.werkzeug python3.pkgs.werkzeug

@FRidh
Copy link
Member

FRidh commented Mar 26, 2019

Does this warrant a backport?

that requires testing all reverse dependencies

@dotlambda
Copy link
Member Author

Does this warrant a backport?

that requires testing all reverse dependencies

I'm not interested in doing that. So I'd say we don't backport unless someone asks us to.

@dotlambda
Copy link
Member Author

This breaks octoprint:

ImportError: cannot import name cached_property

cc @abbradar @peterhoeg

@peterhoeg
Copy link
Member

That's not a big deal - we can just pin werkzeug for octoprint. Would you mind doing that @dotlambda ?

The tests failed with
    ImportError: cannot import name cached_property
after 81dd031.
@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.buildbot-full python3.pkgs.buildbot-full

@dotlambda dotlambda merged commit 2e50136 into NixOS:master Apr 2, 2019
@dotlambda dotlambda deleted the werkzeug-0.15.1 branch April 2, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Werkzerg reloader crashes due to Nix wrapped scripts
5 participants