Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] fix containers ipv6 #58211

Merged
merged 2 commits into from Mar 25, 2019
Merged

[19.03] fix containers ipv6 #58211

merged 2 commits into from Mar 25, 2019

Conversation

andir
Copy link
Member

@andir andir commented Mar 24, 2019

Motivation for this change

backport of #57897

cc @srhb @rnhmjoj

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rnhmjoj and others added 2 commits March 24, 2019 18:17
@rnhmjoj @andir
nixos/containers: create veths if only IPv6 is configured
883fa21 
This fixes the failing nixos.tests.containers-ipv6 test. Thanks to andir.

(cherry picked from commit 552e583)
@andir
nixos/release: make ipv6 tests as important as legacy IP tests
fb28270 
IPv6 container support broke a while ago and we didn't notice it. Making
them part of the (small) release test set should fix that. At this point
in time they should be granted the same amount of importance as the
legacy IP tests.

(cherry picked from commit 862615b)
@andir andir requested a review from infinisil as a code owner March 24, 2019 17:19
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 24, 2019

Thank you.

@flokli flokli merged commit 8916ac0 into NixOS:release-19.03 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @rnhmjoj @flokli @GrahamcOfBorg