Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zbar: 0.10 -> 0.22 (new upstream) #58247

Merged
merged 1 commit into from Mar 25, 2019
Merged

zbar: 0.10 -> 0.22 (new upstream) #58247

merged 1 commit into from Mar 25, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 25, 2019

Motivation for this change

The original upstream at http://zbar.sourceforge.net/ has not produced a
new release or a new commit on their repository in about 7 years. Most
distros (Debian, Gentoo, Arch, ...) have switched already to the more
maintained fork at https://github.com/mchehab/zbar

Update dependencies from qt4 to qt5, reducing "electrum" closure size in
the process (now only depends on one Qt version).

$ nix path-info -Sh /nix/store/1vr26j7z8bdg4d5diln6gzpdrfgaxf26-electrum-3.3.4  # old
/nix/store/1vr26j7z8bdg4d5diln6gzpdrfgaxf26-electrum-3.3.4         1.4G
$ nix path-info -Sh /nix/store/mngfcgfhak1lg3zflw45b6fxkc3l7pzy-electrum-3.3.4  # new
/nix/store/mngfcgfhak1lg3zflw45b6fxkc3l7pzy-electrum-3.3.4         1.2G

Tested with zbarcam-gtk, zbarcam-qt, and electrum's QR code features (generation & scanning).

FYI @7c6f434c current zbar maintainer (added myself to the list at the same time)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
zbar: 0.10 -> 0.22
57ffe86 
The original upstream at http://zbar.sourceforge.net/ has not produced a
new release or a new commit on their repository in about 7 years. Most
distros (Debian, Gentoo, Arch, ...) have switched already to the more
maintained fork at https://github.com/mchehab/zbar

Update dependencies from qt4 to qt5, reducing "electrum" closure size in
the process (now only depends on one Qt version).
@7c6f434c
Copy link
Member

Indeed, I never cared enough about live scanning on desktop to investigate. I guess if Debian Testing has switched, we can switch as well… Thanks. (Waiting for ofBorg build of Qt5 Base — not what I want to do…)

@7c6f434c 7c6f434c merged commit 3791a20 into NixOS:master Mar 25, 2019
@delroth delroth mentioned this pull request Mar 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @7c6f434c @GrahamcOfBorg