Fix cudatoolkit building on non-sandboxed systems #58113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @knedlsepp. |
|
I would rather we disable doInstallCheck until this is properly fixed. |
This fixes cudatoolkit building on non-sandboxed system. The cudatoolkit tests run each of the CUDA binaries as a small smoke test just to make sure they all can at least somewhat run. However, the `cuda-gdb` binary doesn't run correctly on non-sandboxed systems because it picks up versions of Python from /usr/lib. This PR disables the smoke tests for now. They should be re-enabled when we figure out how to make them work for cuda-gdb on non-sandboxed systems. This PR is for NixOS#57939.
cdepillabout
force-pushed
the
ignore-cuda-gdb-without-sandboxing
branch
from
e1b994c
to
54cc6ad
Compare
|
@knedlsepp I added commit 54cc6ad which does as you suggest. Now the install checks are disabled. I also added a comment about why it has been disabled. |
|
Thx. @bendlas, could you have a look. |
|
merged and backported |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
cudatoolkitbuilding on non-sandboxed system.The
cudatoolkittests run each of the CUDA binaries as a small smoketest just to make sure they all can at least somewhat run.
However, the
cuda-gdbbinary doesn't run correctly on non-sandboxedsystems because it picks up versions of Python from /usr/lib.
This PR excludes the
cuda-gdbbinary from these smoke tests socudatoolkit can be built again on non-sandboxed systems.
This PR is for #57939.
This doesn't fix the underlying issue of
cuda-gdbnot being able to run on non-sandboxed systems. That will hopefully come in a future PR. Note thatcuda-gdbnot being able to run doesn't affect the actual cuda libraries that are needed for building CUDA-enabled applications.Once this is merged in, I'd also like to backport this to 19.03.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)