Skip to content

Ghc863 add haskellCompilerName and doc output #58114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Ghc863 add haskellCompilerName and doc output #58114

wants to merge 2 commits into from
+3 −0

Conversation

teto
Copy link
Member

@teto teto commented Mar 22, 2019

I am trying to use hie with ghc863 as ghc864 is not supported yet but met some problems along the way as ghc863 is missing attributes.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

teto added 2 commits March 22, 2019 15:59
@teto
ghc863: add haskellCompilerName to prevent errors
0e84290 
such as:
error: while evaluating anonymous function at /home/teto/mptcpnetlink/hs/default.nix:1:1, called from /home/teto/mptcpnetlink/hs/shell-test.nix:65:6:
while evaluating 'doHaddock' at /home/teto/nixpkgs/pkgs/development/haskell-modules/lib.nix:71:15, called from /home/teto/mptcpnetlink/hs/default.nix:5:1:
while evaluating 'overrideCabal' at /home/teto/nixpkgs/pkgs/development/haskell-modules/lib.nix:37:24, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/lib.nix:71:20:
while evaluating 'callCabal2nix' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:206:32, called from /home/teto/mptcpnetlink/hs/default.nix:5:24:
while evaluating 'callCabal2nixWithOptions' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:191:66, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:206:38:
while evaluating 'overrideCabal' at /home/teto/nixpkgs/pkgs/development/haskell-modules/lib.nix:37:24, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:202:10:
while evaluating 'callPackageKeepDeriver' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:156:33, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:202:25:
while evaluating 'overrideCabal' at /home/teto/nixpkgs/pkgs/development/haskell-modules/lib.nix:37:24, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:157:5:
while evaluating 'callPackage' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:114:22, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:157:20:
while evaluating 'callPackageWithScope' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:74:37, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:114:28:
while evaluating 'makeOverridable' at /home/teto/nixpkgs/lib/customisation.nix:67:24, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:97:8:
while evaluating 'drvScope' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:87:18, called from /home/teto/nixpkgs/lib/customisation.nix:69:12:
while evaluating the attribute 'installPhase' of the derivation 'cabal2nix-netlink-pm' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:125:7:
while evaluating the attribute 'ghc.haskellCompilerName' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:318:5:
attribute 'haskellCompilerName' missing, at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:135:32
@teto
ghc863: similarly to solve ghcWithHoogle problem
77c0d6c 
error: while evaluating the attribute 'NIX_GHC' of the derivation 'ghc-shell-for-netlink-pm-1.0.0' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:301:9:
while evaluating 'ghcWithHoogle' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:238:21, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:292:18:
while evaluating 'withPackages' at /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:116:18, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:244:10:
while evaluating 'callPackageWith' at /home/teto/nixpkgs/lib/customisation.nix:108:35, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:116:28:
while evaluating 'makeOverridable' at /home/teto/nixpkgs/lib/customisation.nix:67:24, called from /home/teto/nixpkgs/lib/customisation.nix:112:8:
while evaluating anonymous function at /home/teto/nixpkgs/pkgs/development/haskell-modules/with-packages-wrapper.nix:1:1, called from /home/teto/nixpkgs/lib/customisation.nix:69:12:
while evaluating 'closePropagation' at /home/teto/nixpkgs/lib/deprecated.nix:160:22, called from /home/teto/nixpkgs/pkgs/development/haskell-modules/with-packages-wrapper.nix:45:57:
while evaluating 'uniqList' at /home/teto/nixpkgs/lib/deprecated.nix:91:14, called from /home/teto/nixpkgs/lib/deprecated.nix:160:29:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:98:8:
while evaluating 'innerClosePropagation' at /home/teto/nixpkgs/lib/deprecated.nix:143:32, called from /home/teto/nixpkgs/lib/deprecated.nix:160:52:
while evaluating 'innerClosePropagation' at /home/teto/nixpkgs/lib/deprecated.nix:143:32, called from /home/teto/nixpkgs/lib/deprecated.nix:151:21:
while evaluating 'uniqList' at /home/teto/nixpkgs/lib/deprecated.nix:91:14, called from /home/teto/nixpkgs/lib/deprecated.nix:153:24:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:98:8:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating 'go' at /home/teto/nixpkgs/lib/deprecated.nix:92:18, called from /home/teto/nixpkgs/lib/deprecated.nix:97:27:
while evaluating the attribute 'buildPhase' of the derivation 'hoogle-local-0.1' at /home/teto/nixpkgs/pkgs/development/haskell-modules/hoogle.nix:57:3:
attribute 'doc' missing, at /home/teto/nixpkgs/pkgs/development/haskell-modules/hoogle.nix:40:10
@teto teto requested review from basvandijk and peti as code owners March 22, 2019 07:05
@matthewbauer
Copy link
Member

Note that this is ghc863Binary not ghc863. I'm under the impression it was just used for bootstrapping, although you can probably use it for other things as well.

@teto
Copy link
Member Author

teto commented Mar 22, 2019 via email

@peti
Copy link
Member

peti commented Mar 23, 2019

As a haskell beginner i don t know the diference between the binary version and other.

The binary versions are downloaded from haskell.org for bootstrapping purposes. Their only purpose is to compile the real compiler from source and they are not supposed to be used for anything else.

peti
peti reviewed Mar 23, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not give users the impression that pre-built binary compilers ought to be used just like the real ones. That compiler is supposed to bootstrap ghc-8.6.3 and not much else.

👎

@teto
Copy link
Member Author

teto commented Mar 23, 2019

I'll close then. thanks for feedback.

@teto teto closed this Mar 23, 2019
@teto teto deleted the ghc863_name branch May 13, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

@basvandijk basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @matthewbauer @peti @GrahamcOfBorg