Microsoft Teams notification plugin #646
Open
+218
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if for simplicity and clarity, it might be worth not trying to abstract them? |
|
@grahamc You mean, just duplicate 70% of the SlackNotification.pm code in MicrosoftTeamsNotification.pm? Or move the common code into some sort of imported utility class instead of trying to use inheritance? |
|
I gave up on the fancy inheritance structure, since I'm having trouble even building Hydra to test the code to see what went wrong. Instead I just let the MSTeams plugin duplicate some code (ugh) from the Slack plugin. Though I've factored out a few common operations into a separate util file, to make it less horrible. |
|
Running hydra should be easier since: #759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new notification plugin for Microsoft Teams, for those of us who aren't on Slack.
I refactored the existing SlackNotification.pm into a pseudo-abstract class called RichMessengerNotification.pm (I don't think Perl has "real" abstract classes, but I could be wrong), then had both SlackNotification.pm and the new MicrosoftTeamsNotification.pm inherit from it.
I have no prior experience with Perl, definitely no experience with Perl inheritance, and no clear idea of how to test this thing. It might be completely broken right now. Any advice would be appreciated.