Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anbox: cleanup #58143

Merged
merged 1 commit into from Mar 23, 2019
Merged

anbox: cleanup #58143

merged 1 commit into from Mar 23, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Mar 22, 2019 •
edited

Use trivial builders for all the text manipulation and use runtimeShell

Motivation for this change

Didn't get a chance to review #57826 so I thought to submit the changes I would have requested anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @gebner

@worldofpeace
anbox: cleanup
1e2b834 
Use trivial builders for all the text manipulation and use runtimeShell
@gebner
Copy link
Member

gebner commented Mar 23, 2019

LGTM.

@gebner gebner merged commit d5a533d into NixOS:master Mar 23, 2019
@worldofpeace worldofpeace deleted the anbox-nits branch March 24, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @gebner @GrahamcOfBorg