Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py-radix: init at v0.10.0 #58145

Closed
wants to merge 4 commits into from
Closed

Py-radix: init at v0.10.0 #58145

wants to merge 4 commits into from

Conversation

mkgvt
Copy link
Contributor

@mkgvt mkgvt commented Mar 22, 2019

Motivation for this change

Packaged py-radix library for inclusion in nixpkgs.

Things done

Created pkgs/development/python-modules/py-radix/default.nix.
Modified pkgs/top-level/python-packages.nix.
Built against: Python 2.7, 3.5, 3.6, 3.7
Tested user installation: nix-env -i python36.pkgs.py-radix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkgvt mkgvt requested a review from FRidh as a code owner March 22, 2019 20:04
aanderse
aanderse reviewed Mar 23, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the rename package here?

@mkgvt
Copy link
Contributor Author

mkgvt commented Mar 23, 2019 via email

@aanderse
Copy link
Member

I figured as much, no problem. Are you familiar at all with the process of rewriting your git commits to cleanup these PRs?

@mkgvt
Copy link
Contributor Author

mkgvt commented Mar 23, 2019 via email

@aanderse
Copy link
Member

ping @mkgvt

@mkgvt
Copy link
Contributor Author

mkgvt commented Apr 15, 2019

Still here.

@aanderse
Copy link
Member

Can you please cleanup the git history? I'm looking for a single commit. You also still need to remove the commit where you dropped a perl package.

FRidh
FRidh reviewed Apr 16, 2019
View reviewed changes
pkgs/development/python-modules/py-radix/default.nix
sha256 = "01xyn9lg6laavnzczf5bck1l1c2718ihxx0hvdkclnnxjqhbrqis";
};

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default, so remove

@mkgvt mkgvt mentioned this pull request May 10, 2019
Merged
10 tasks
@mkgvt
Copy link
Contributor Author

mkgvt commented May 10, 2019

Hopefully I have fixed the issues with this PR in #61251.

@aanderse aanderse closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@aanderse aanderse aanderse left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mkgvt @aanderse @FRidh @dotlambda @infinisil @GrahamcOfBorg @mkgardner