Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bicon: init at unstable-2018-08-10 #58128

Merged
merged 1 commit into from Apr 14, 2019
Merged

bicon: init at unstable-2018-08-10 #58128

merged 1 commit into from Apr 14, 2019

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Mar 22, 2019 •
edited

Motivation for this change

Persian, arabic users sometimes need a console to support RTL very well.
Bicon gives you that console :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

samueldr
samueldr previously requested changes Mar 22, 2019
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for the contribution!

Spotted some minor, some less minor changes, but otherwise looks relatively good (without having built or tested yet, next step).

pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bicon/default.nix Outdated Show resolved Hide resolved
@samueldr
Copy link
Member

@GrahamcOfBorg build bicon

@samueldr samueldr dismissed their stale review March 24, 2019 18:39

Changes made

samueldr
samueldr requested changes Mar 24, 2019
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update :). Some minor things to look for:

We'll need the (two) commits squashed, and with the commit message mentioning the right version, instead of the revision.

bicon: init at unstable-2018-08-10

@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 24, 2019 •
edited

Done.
Edit: Sorry if i messed up something.

@LinArcX LinArcX requested a review from FRidh as a code owner March 24, 2019 20:02
@LinArcX LinArcX changed the title bicon: init at 38725c0 init at unstable-2018-08-10 Mar 24, 2019
@LinArcX LinArcX changed the title init at unstable-2018-08-10 Bicon: init at unstable-2018-08-10 Mar 24, 2019
@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 27, 2019

@samueldr What happend?

@veprbl
Copy link
Member

veprbl commented Mar 30, 2019

Otherwise LGTM

@LinArcX LinArcX changed the title Bicon: init at unstable-2018-08-10 bicon: init at unstable-2018-08-10 Mar 31, 2019
@LinArcX LinArcX force-pushed the bicon branch 2 times, most recently from 3c4614c to b8cb23a Compare April 7, 2019 08:09
@LinArcX
bicon: init at unstable-2018-08-10
fd898f6 
bicon: init at unstable-2018-08-10
@veprbl
Copy link
Member

veprbl commented Apr 14, 2019

@GrahamcOfBorg build bicon

@veprbl veprbl merged commit 75b781f into NixOS:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@samueldr samueldr samueldr requested changes

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LinArcX @samueldr @veprbl @symphorien @GrahamcOfBorg