-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seperator of signal names in records causes ambiguity #48
Comments
This ambiguity was something I expected when writing that code. The problem with |
What about using the what do you think? |
I think |
I like that :). Should I create a PR? |
Sure. |
When creating a
Record
, the signals inside it are namedrecordname_fieldname
currently.This makes it hard to see the hierarchy when using snake case names for records and fields as well. I.e. having a record named
some_record
with a field namedsome_field
the resulting signal is calledsome_record_some_field
which could also be the name of a signal in a nested record with depth 3.I propose to use another character for separation (for example
.
), which would lead tosome_record.some_field
in that case.(see: https://github.com/m-labs/nmigen/blob/master/nmigen/hdl/rec.py#L75)
The text was updated successfully, but these errors were encountered: