Skip to content

anbox: Prevent eval failure on non-existent arches #58150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2019
Merged

anbox: Prevent eval failure on non-existent arches #58150

merged 1 commit into from
Mar 23, 2019
+7 −10

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 22, 2019 •
edited
Loading

Motivation for this change

Fix tarball generation / eval during i686-linux check

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@srhb srhb requested a review from edwtjo March 22, 2019 22:30
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 22, 2019
@srhb
Copy link
Contributor Author

srhb commented Mar 23, 2019

@volth It's a good addition, but it's not sufficient to prevent eval failures in all the meta checks during CI, I'm afraid, due to the way the passthru is handled. Added.

@srhb
Copy link
Contributor Author

srhb commented Mar 23, 2019

@volth Nevermind, you're right. I could have sworn I tried that yesterday. Thanks! :)

@srhb srhb merged commit c987fe4 into NixOS:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @GrahamcOfBorg