Skip to content

haskellPackages.hfsevents: Fix eval on Darwin #58149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

haskellPackages.hfsevents: Fix eval on Darwin #58149

wants to merge 1 commit into from
+1 −1

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 22, 2019 •
edited
Loading

Motivation for this change

hfsevents is currently marked as broken on Darwin, which in turn prevents evaluation of the entire darwin tested set (through stack.) This fixes it.

#58028 fixed the configuration for hackage2nix, so the next rerun will fix it. We need a stopgap measure to get darwin-tested evaluating again, however, and this does it by simply mangling hackage-packages.nix to fix platforms.

Needs a backport to 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@srhb srhb requested review from basvandijk and peti as code owners March 22, 2019 22:05
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: haskell 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 22, 2019
@srhb srhb added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 23, 2019
@srhb srhb force-pushed the fix-stack-eval-darwin branch from a760013 to 35059ac Compare March 24, 2019 10:55
@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 24, 2019
@srhb srhb force-pushed the fix-stack-eval-darwin branch from 35059ac to a28c058 Compare March 24, 2019 11:04
@srhb srhb closed this Mar 24, 2019
@srhb srhb deleted the fix-stack-eval-darwin branch March 24, 2019 11:06
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@peti peti

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 6.topic: haskell 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @samueldr @GrahamcOfBorg