Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Edge to edge_webdriver by default #16054

Closed
gsnedders opened this issue Mar 25, 2019 · 8 comments
Closed

Move Edge to edge_webdriver by default #16054

gsnedders opened this issue Mar 25, 2019 · 8 comments
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

Split from #12374:

Edge is mostly waiting for Windows 10 RS5 to rollout to more users (given plenty of people still don't have it)

I don't know if we should flip the switch now? I know @foolip has been having problems, but I don't know if they're actually worse with this than Selenium.

@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run priority:roadmap labels Mar 25, 2019
@foolip
Copy link
Member

foolip commented Mar 25, 2019

This is the setup we use in Azure Pipelines anyway, so I say let's do it. The only reason I could see not to is if @mustjab or @thejohnjansen think the trouble we're having in Azure Pipelines wouldn't occur if we used Selenium instead.

@gsnedders
Copy link
Member Author

Or if we care about older releases of Edge, I guess.

@foolip
Copy link
Member

foolip commented Mar 25, 2019

I don't think that would be worth keeping working, but I'll let @mustjab and @thejohnjansen speak to that.

@thejohnjansen
Copy link
Contributor

I have no reason to believe that the issues with Azure Pipelines would not occur if we used Selenium instead, and I also don't think we should worry about older releases of Edge... :-)

@thejohnjansen
Copy link
Contributor

So, I think this should be fine.

@foolip
Copy link
Member

foolip commented Mar 25, 2019

@gsnedders please go ahead :)

@foolip
Copy link
Member

foolip commented Jun 10, 2019

@gsnedders given that we're now using edgechromium on Azure Pipelines it won't matter all that much, but this would probably still be nice cleanup. Lowering prio though.

@foolip
Copy link
Member

foolip commented May 6, 2021

This is about EdgeHTML (Edge 12-18) and there's a new product called "edgechromium" for Edge 79+. Closing because I don't think we should be doing any cleanup for EdgeHTML, only eventually remove support.

@foolip foolip closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

3 participants