haskellPackages.superbuffer: fix build #58199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can edit |
peti
requested changes
Mar 24, 2019
|
@GrahamcOfBorg build haskellPackages.superbuffer |
peti
approved these changes
Mar 25, 2019
peti
reviewed
Mar 25, 2019
| # https://github.com/agrafix/superbuffer/pull/2 | ||
| superbuffer = overrideCabal super.superbuffer (drv: { | ||
| postPatch = '' | ||
| sed -i 's#QuickCheck < 2.10#QuickCheck < 2.13#' superbuffer.cabal |
There was a problem hiding this comment.
If you wanted to go all out you could fetchpatch that change from https://github.com/agrafix/superbuffer/pull/2.patch and apply it instead of using sed. It's not a big difference, but the advantage is that the patch will fail to apply once an update comes out that fixes the issue and then we'll notice that the patch can be removed.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I have a package that depends on this.
Things done
nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)QuickCheck is used for tests, which passes even on more recent versions, so I removed the constaint.
Should I regenerate hackage-packages or wait it for it to be automatically generated?