Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.composer: 1.8.0 -> 1.8.4 #58201

Merged
merged 2 commits into from Mar 24, 2019
Merged

phpPackages.composer: 1.8.0 -> 1.8.4 #58201

merged 2 commits into from Mar 24, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 24, 2019

Motivation for this change

Changelogs:
https://github.com/composer/composer/releases/tag/1.8.1
https://github.com/composer/composer/releases/tag/1.8.2
https://github.com/composer/composer/releases/tag/1.8.3
https://github.com/composer/composer/releases/tag/1.8.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu added 2 commits March 24, 2019 11:08
@etu
phpPackages.composer: 1.8.0 -> 1.8.4
afa88c8 
Changelogs:
https://github.com/composer/composer/releases/tag/1.8.1
https://github.com/composer/composer/releases/tag/1.8.2
https://github.com/composer/composer/releases/tag/1.8.3
https://github.com/composer/composer/releases/tag/1.8.4
@etu
phpPackages.composer: Add unzip to path
52fa2d4 
Unzip is used by composer to install dependencies etc. If it's not
there it defaults to using PHP's built in zip functions. But they are
slower and composer complains to the user if this happens.
jtojnar
jtojnar approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@etu etu merged commit 5699e8e into NixOS:master Mar 24, 2019
@etu etu deleted the php-composer-update branch March 24, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@globin globin Awaiting requested review from globin globin is a code owner

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @jtojnar @GrahamcOfBorg