postgresql: always create the bin directory in postgresqlAndPlugins #58251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
marsam
force-pushed
the
postgresql-plugins-bin
branch
from
393e697
to
00fac46
Compare
This is needed because some PostgreSQL plugins don't have a bin
directory. If only these plugins are listed in cfg.extraPlugins buildEnv
will turn $out/bin into a symbolic link to ${pg}/bin. Lateron we try to
rm $out/bin/{pg_config,postgres,pg_ctl} which will then fail because
$out/bin will be read-only.
marsam
force-pushed
the
postgresql-plugins-bin
branch
from
00fac46
to
517c52e
Compare
|
@marsam Is this PR still valid? Are you just waiting for review from someone like @thoughtpolice, @danbst, or @aszlig? |
yes, is still valid. I'd really appreciate a review of the PostgreSQL package maintainers |
7c6f434c
approved these changes
Jul 16, 2019
danbst
approved these changes
Jul 16, 2019
|
Thanks team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because some PostgreSQL plugins don't have a bin$out/bin into a symbolic link to $ {pg}/bin. Lateron
directory. If only these plugins are listed in cfg.extraPlugins
buildEnv will turn
we try to rm $out/bin/{pg_config,postgres,pg_ctl} which will then fail
because $out/bin will be read-only.
Rebased from #44379, which didn't get merged
Closes #22653
backport please
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)