Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2019 03 25 monero 14.0.2 #58250

Merged
merged 2 commits into from Mar 26, 2019
Merged

2019 03 25 monero 14.0.2 #58250

merged 2 commits into from Mar 26, 2019

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Mar 25, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thedavidmeister
Copy link
Contributor Author

cleanup from #57247

tested with nix-shell -p nix-review --run "nix-review pr 58250"

@thedavidmeister
Copy link
Contributor Author

thedavidmeister commented Mar 25, 2019 •
edited

testing w/ ledger firmware 1.5.5 + ledger monero app 1.2.2

export NIXPKGS=`pwd`
nix-build $NIXPKGS -A monero-gui --run-env
monerod

[thedavidmeister@nixos:~/nixpkgs]$ nix-build $NIXPKGS -A monero-gui --run-env

[nix-shell:~/nixpkgs]$ monerod
2019-03-25 11:43:40.811     7f89bfa7bc40        INFO    global  src/daemon/main.cpp:287 Monero 'Boron Butterfly' (v0.14.0.2-unknown)
2019-03-25 11:43:40.811     7f89bfa7bc40        INFO    global  src/daemon/protocol.h:53        Initializing cryptonote protocol...

cli wallet also works

@thedavidmeister thedavidmeister mentioned this pull request Mar 25, 2019
Closed
10 tasks
@thedavidmeister
Copy link
Contributor Author

note the GUI is broken in master, with a pending fix in #57921

@thedavidmeister thedavidmeister changed the title WIP: 2019 03 25 monero 14.0.2 2019 03 25 monero 14.0.2 Mar 25, 2019
@thedavidmeister
Copy link
Contributor Author

@rnhmjoj fyi

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 25, 2019

Seems good to me. Can we merge it yet?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 25, 2019

Btw, you don't need to recreate a PR: you can do an interactive rebase (git rebase -i HEAD~3 for 3 commits) and the force push.

@thedavidmeister
Copy link
Contributor Author

@rnhmjoj yeah i'm happy to merge, thanks for the tip

i can't actually merge tho, who has the right permissions?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 26, 2019

Yeah, we have to ask. Ping @Mic92 @xeji who reviewed monero stuff earlier.

@infinisil infinisil merged commit 007e94c into NixOS:master Mar 26, 2019
@infinisil infinisil mentioned this pull request Mar 26, 2019
Closed
@rnhmjoj rnhmjoj mentioned this pull request Mar 27, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thedavidmeister @rnhmjoj @infinisil @GrahamcOfBorg