Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zeronet: add fileserverPort option #58181

Merged
merged 1 commit into from
Apr 27, 2019
Merged

nixos/zeronet: add fileserverPort option #58181

merged 1 commit into from
Apr 27, 2019
+12 −1

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 23, 2019

Motivation for this change

Without it, zeronet tried to write one to the read-only config file and
crashed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @Chiiruno

Sorry, something went wrong.

@fgaz
nixos/zeronet: add fileserverPort option

Verified

This commit was signed with the committer’s verified signature.
afreakk Hans
GPG key ID: 8B980523664C3A52
Verified
Learn about vigilant mode
58f6827 
Without it, zeronet tried to write one to the read-only config file and
crashed
@fgaz fgaz requested a review from infinisil as a code owner March 23, 2019 17:01
@fgaz fgaz mentioned this pull request Mar 23, 2019
Merged
10 tasks
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 23, 2019
@ghost
Copy link

ghost commented Mar 23, 2019

LGTM

@Lassulus Lassulus merged commit 21fe4fd into NixOS:master Apr 27, 2019
@fgaz fgaz deleted the nixos/zeronet/fix1 branch May 11, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @Lassulus @GrahamcOfBorg